-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reserved word option to Pistache and Restbed generators #5418
Conversation
@@ -156,12 +157,18 @@ public void processOpts() { | |||
supportingFiles.add(new SupportingFile("cmake.mustache", "", "CMakeLists.txt")); | |||
supportingFiles.add(new SupportingFile("README.mustache", "", "README.md")); | |||
} | |||
if (additionalProperties.containsKey(RESERVED_WORD_PREFIX_OPTION)) | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI. I'll move {
to the previous line to follow the Java style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done via #5424
…ools#5418) * Add reserved word option to Pistache and Restbed generators * Regenerate docs
@alexweav thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
Completes a leftover task for #5269. That PR fixed issue #5268, but did not propagate the fix into all code generators, since some of them clear the base class's CLI options. This ensures that the added CLI option in the linked PR also appears in the Restbed and Pistache C++ generators.
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.